Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View loading: stacktrace and error #6346

Closed
benoc617 opened this issue Aug 22, 2019 · 0 comments · Fixed by #6352

Comments

@benoc617
Copy link

commented Aug 22, 2019

Expected Behavior

Previously saved view opens

Current Behavior

  • Immediately after logging into graylog with a fresh browser, choose a previously saved view
  • Get error with the following stacktrace:

`Cannot read property 'title' of undefined

Stack Trace:

TypeError: Cannot read property 'title' of undefined
at t._isNewView (https://logs.d-gurus.net/assets/ExtendedSearchPage.60a2621478c6c8ca385c.js:1:132926)
at t.render (https://logs.d-gurus.net/assets/ExtendedSearchPage.60a2621478c6c8ca385c.js:1:133229)
at ka (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:63009)
at Sa (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:62804)
at Da (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:66638)
at Fo (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:90682)
at Vo (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:91066)
at Ys (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:97953)
at Ss (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:97333)
at Ls (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:96354)
at Zo (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:95228)
at Object.enqueueSetState (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:18:44755)
at t.b.setState (https://logs.d-gurus.net/assets/vendor.91c91d4a31d54d96392a.js:26:1665)
at https://logs.d-gurus.net/assets/ShowViewPage.60a2621478c6c8ca385c.js:1:2235
at s (https://logs.d-gurus.net/assets/app.60a2621478c6c8ca385c.js:102:224951)
at P._settlePromiseFromHandler (https://logs.d-gurus.net/assets/app.60a2621478c6c8ca385c.js:102:198233)
at P._settlePromise (https://logs.d-gurus.net/assets/app.60a2621478c6c8ca385c.js:102:199033)
at P._settlePromise0 (https://logs.d-gurus.net/assets/app.60a2621478c6c8ca385c.js:102:199732)
at P._settlePromises (https://logs.d-gurus.net/assets/app.60a2621478c6c8ca385c.js:102:201059)
at https://logs.d-gurus.net/assets/app.60a2621478c6c8ca385c.js:102:154681

Component Stack:

in ViewActionsMenu
in ConnectStoresWrapper[ViewActionsMenu] stores=metadata,view,currentUser
in span
in span
in u
in w
in ConnectStoresWrapper[w] stores=queries,queryTitles,viewMetadata
in withRouter(ConnectStoresWrapper[w] stores=queries,queryTitles,viewMetadata)
in div
in t
in ExtendedSearchPage
in ConnectStoresWrapper[ExtendedSearchPage] stores=executionState
in Unknown
in t
in ConnectStoresWrapper[t] stores=executionState
in Unknown
in n
in div
in t
in div
in t
in div
in t
in div
in t
in t
in withRouter(t)
in div
in App
in RouterContext
in Router
in h
in t
in n
in AppFacade`

Possible Solution

  • Not a solution, but a workaround is to first enter the "create new" view mode
  • Once that page is visited, loading a saved view works fine.

Steps to Reproduce (for bugs)

  • Create new view
  • Log out of graylog / restart browser
  • Log into graylog again
  • Select "load existing" from "views" menu
  • Choose created view

Context

  • Just trying to set up views and allow our users to use them

Your Environment

  • Graylog Version: 3.1.0-1
  • Elasticsearch Version: 6.5.4
  • MongoDB Version: 3.6
  • Operating System: CoreOS (kernel 4.13.16-coreos-r2)
  • Browser version: Chrome 76, safari 12.1.1

@dennisoelkers dennisoelkers self-assigned this Aug 26, 2019

dennisoelkers added a commit that referenced this issue Aug 26, 2019
Wait for `ViewActions.load` in promise chain and still return view.
Before this change, calling the `ViewActions.load` action from
`ViewDeserializer` was not returning the promise of it, so it was not
waited upon to resolve. This lead to an issue, where loading the view
took longer than toggling the `loaded` status flag in `ShowViewPage`,
leading to rendering components which relied on the view being loaded
already.

This change is now returning the promise received from
`ViewActions.load`, so it is waited on.

Fixes #6346.

@kmerz kmerz closed this in #6352 Aug 26, 2019

kmerz added a commit that referenced this issue Aug 26, 2019
Wait for `ViewActions.load` in promise chain and still return view. (#…
…6352)

Before this change, calling the `ViewActions.load` action from
`ViewDeserializer` was not returning the promise of it, so it was not
waited upon to resolve. This lead to an issue, where loading the view
took longer than toggling the `loaded` status flag in `ShowViewPage`,
leading to rendering components which relied on the view being loaded
already.

This change is now returning the promise received from
`ViewActions.load`, so it is waited on.

Fixes #6346.
kmerz added a commit that referenced this issue Aug 28, 2019
Wait for `ViewActions.load` in promise chain and still return view. (#…
…6352)

Before this change, calling the `ViewActions.load` action from
`ViewDeserializer` was not returning the promise of it, so it was not
waited upon to resolve. This lead to an issue, where loading the view
took longer than toggling the `loaded` status flag in `ShowViewPage`,
leading to rendering components which relied on the view being loaded
already.

This change is now returning the promise received from
`ViewActions.load`, so it is waited on.

Fixes #6346.
dennisoelkers added a commit that referenced this issue Aug 28, 2019
Wait for `ViewActions.load` in promise chain and still return view. (#…
…6352)

Before this change, calling the `ViewActions.load` action from
`ViewDeserializer` was not returning the promise of it, so it was not
waited upon to resolve. This lead to an issue, where loading the view
took longer than toggling the `loaded` status flag in `ShowViewPage`,
leading to rendering components which relied on the view being loaded
already.

This change is now returning the promise received from
`ViewActions.load`, so it is waited on.

Fixes #6346.
kmerz added a commit that referenced this issue Aug 28, 2019
Wait for `ViewActions.load` in promise chain and still return view. (#…
…6352) (#6361)

Before this change, calling the `ViewActions.load` action from
`ViewDeserializer` was not returning the promise of it, so it was not
waited upon to resolve. This lead to an issue, where loading the view
took longer than toggling the `loaded` status flag in `ShowViewPage`,
leading to rendering components which relied on the view being loaded
already.

This change is now returning the promise received from
`ViewActions.load`, so it is waited on.

Fixes #6346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.