Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot focus input fields in modal form (Dashboard) #6356

Closed
mehrenreich opened this issue Aug 27, 2019 · 1 comment · Fixed by #6431

Comments

@mehrenreich
Copy link

commented Aug 27, 2019

When trying to modify a dashboard widget, it's not possible to directly focus a field inside the modal form with the mouse pointer. Since seems to be related to the 3.1 release.

Expected Behavior

In prior versions it was possible to select a field by clicking into it and modify the contents.

Current Behavior

Once you try to select a field, the focus is lost immediately. You can TAB through the form, but not select it with the mouse pointer.

Aug-27-2019 13-47-55

Possible Solution

Steps to Reproduce (for bugs)

  1. Open a dashboard
  2. Enter "Unlock / Edit" mode
  3. Click on the pencil icon within a widget
  4. Try to select a field inside the modal form

Context

Your Environment

  • Graylog Version: Graylog 3.1.0+aa5175e
  • Browser version: Safari, Chrome
@dennisoelkers dennisoelkers self-assigned this Aug 28, 2019
@dennisoelkers dennisoelkers added this to the 3.1.1 milestone Aug 28, 2019
@linuspahl

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

It looks like a common problem with the drag and drop library.

I found this related issue (not the same library, but the same problem and their solution works for this case as well)
atlassian/react-beautiful-dnd#110

The easiest fix is to add onMouseDown={e => e.stopPropagation()} for the Modal Inputs.
But it is not a perfect solution, because you would have to remember this, when adding another Input inside any draggable component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.