New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio configuration overrides message_journal_enabled in code #927

Closed
kroepke opened this Issue Jan 27, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Jan 27, 2015

This is a major code smell, because the InputBufferImpl depends on configuration.isMessageJournalEnabled to set up the correct processing pipeline.
Unfortunately radio shares this code and does the wrong thing if the default setting is true in BaseConfiguration.

Fixing #924 broke this.

@kroepke kroepke added the bug label Jan 27, 2015

@kroepke kroepke added this to the 1.1.0 milestone Jan 27, 2015

kroepke added a commit that referenced this issue Jan 27, 2015

disable journal in radio process by default
NoopJournal now throws exceptions when being used (this masked discarding messages in radio, if message_journal_enabled was set)

see #927

@kroepke kroepke removed this from the 1.1.0 milestone May 29, 2015

@bernd

This comment has been minimized.

Member

bernd commented Aug 7, 2015

Closing this now because radio is deprecated and the smelly code will be gone once radio is gone.

@bernd bernd closed this Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment