New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple grok patterns with the same name can be created #937

Closed
cmock opened this Issue Feb 2, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@cmock

cmock commented Feb 2, 2015

Running 1.0.0-8.rc.1from the Debian packages.

It is possible to create multiple grok patterns with the same name, both via the "create pattern" dialog and by importing from file (both by importing the same file twice, and by having multple patterns with the same name in a single file).

What should happen:

  • When using the "create pattern" dialog, it should be impossible to save a pattern with an already-existing name.

  • When importing a file, some sort of conflict resolution would be needed. This could be on a per-file level: if the newly imported file contains names that are already present, the user should have the choice to:

    • cancel processing of that file
    • overwrite existing patterns

    This would cover my usecase of keeping grok patterns in files, editing them there and importing them. Other usecases may be better served by a conflict resolution on a per-pattern basis.

@bernd bernd added the bug label Feb 4, 2015

@bernd bernd added this to the 1.0.1 milestone Feb 4, 2015

@kroepke

This comment has been minimized.

Member

kroepke commented Mar 3, 2015

easiest solution is to do two things:

  1. validate individual patterns in the client (js code) when editing
  2. add "replace all patterns" checkbox to bulk import to allow overwriting all existing patterns, such as when uploading patterns from authoritative source

@bernd bernd self-assigned this Mar 4, 2015

bernd added a commit that referenced this issue Mar 5, 2015

Add "replace" query param to Grok bulk import REST API endpoint.
Existing Grok patterns will be removed before adding the new ones if set
to true.

Fixes #937
Refs graylog-labs/graylog2-web-interface#1150

bernd added a commit to graylog-labs/graylog2-web-interface that referenced this issue Mar 5, 2015

@bernd bernd closed this in 107f06b Mar 5, 2015

@Svolentin

This comment has been minimized.

Svolentin commented Apr 5, 2017

Patterns can be added multiple times via Apply content button:
screen shot 2017-04-05 at 16 11 24
Graylog server 2.2.3

@jalogisch

This comment has been minimized.

Member

jalogisch commented Apr 6, 2017

@Svolentin

please do not highjack old long closed issue with something new.

If you are facing some issue, please open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment