New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make time zone for FlexibleDateConverter configurable #1166

Merged
merged 3 commits into from May 22, 2015

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented May 21, 2015

This PR adds the configuration option time_zone to the FlexibleDateConverter which enables users to override the default time zone (default: UTC).

@joschi joschi added this to the 1.1.0 milestone May 21, 2015

@bernd

This comment has been minimized.

Member

bernd commented May 21, 2015

Please remember to also update the flexible date converter docs.

Should we somehow mention this in the 1.1 upgrade guide? Because the behavior has been changed unintentionally in 0cc9a99 (Nov 2014). The code comment and documentation says that the local time zone will be used.

/cc @lennartkoopmann because you wrote this one

@bernd

This comment has been minimized.

Member

bernd commented May 21, 2015

LGTM otherwise 👍

joschi added a commit to Graylog2/documentation that referenced this pull request May 21, 2015

joschi added a commit to graylog-labs/graylog2-web-interface that referenced this pull request May 21, 2015

@joschi joschi merged commit 3bca7bc into master May 22, 2015

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the configurable-flexible-date-converter branch May 22, 2015

joschi added a commit to Graylog2/documentation that referenced this pull request May 22, 2015

joschi added a commit that referenced this pull request May 22, 2015

joschi added a commit that referenced this pull request May 22, 2015

Change default time zone for FlexibleDateConverter to "Etc/UTC"
Unfortunately DateTimeZone.UTC and DateTimeZone.forID("Etc/UTC") are not equal but actually
are for all practical reasons.

Refs #1166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment