Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix dynamic keyword time-ranges for dashboard widgets created from content packs #1308
Conversation
joschi
added some commits
Jul 17, 2015
joschi
added
bug
ready-for-review
labels
Jul 17, 2015
joschi
added this to the 1.1.5 milestone
Jul 17, 2015
kroepke
self-assigned this
Jul 17, 2015
kroepke
reviewed
Jul 17, 2015
| @@ -99,8 +84,6 @@ public DateTime getTo() { | ||
| public String toString() { | ||
| return MoreObjects.toStringHelper(this) | ||
| .add("keyword", getKeyword()) | ||
| .add("from", getFrom()) | ||
| .add("to", getTo()) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Apart from the minor question above, lgtm. |
added a commit
that referenced
this pull request
Jul 17, 2015
joschi
merged commit d8ea2e6
into
1.1
Jul 17, 2015
joschi
deleted the
web-issue-1533
branch
Jul 17, 2015
joschi
removed
the
ready-for-review
label
Jul 17, 2015
added a commit
that referenced
this pull request
Jul 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
joschi commentedJul 17, 2015
Keyword time-ranges are static by default but should be dynamic for dashboard widgets created from content packs.
This PR additionally makes
KeywordRangedynamically evaluate the keyword by default and removes the static behaviour completely to prevent accidental usage.Fixes graylog-labs/graylog2-web-interface#1533