Fix dynamic keyword time-ranges for dashboard widgets created from content packs #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2015 11:27
Keyword time-ranges are static by default but should be dynamic for dashboard widgets created from content packs. Refs #956 Fixes graylog-labs/graylog2-web-interface#1533
The static behaviour has been removed completely to prevent accidental usage. Refs #956
| @@ -99,8 +84,6 @@ public DateTime getTo() { | |||
| public String toString() { | |||
| return MoreObjects.toStringHelper(this) | |||
| .add("keyword", getKeyword()) | |||
| .add("from", getFrom()) | |||
| .add("to", getTo()) | |||
There was a problem hiding this comment.
Don't these make sense in debug output?
There was a problem hiding this comment.
Yeah, I'll add them back.
|
Apart from the minor question above, lgtm. |
joschi
added a commit
that referenced
this pull request
Jul 17, 2015
Fix dynamic keyword time-ranges for dashboard widgets created from content packs
joschi
added a commit
that referenced
this pull request
Jul 17, 2015
Fix dynamic keyword time-ranges for dashboard widgets created from content packs (cherry picked from commit d8ea2e6)
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword time-ranges are static by default but should be dynamic for dashboard widgets created from content packs.
This PR additionally makes
KeywordRangedynamically evaluate the keyword by default and removes the static behaviour completely to prevent accidental usage.Fixes graylog-labs/graylog2-web-interface#1533