Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Alarmcallback History #1313

Merged
merged 19 commits into from Jul 30, 2015
Merged

Feature: Alarmcallback History #1313

merged 19 commits into from Jul 30, 2015

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jul 21, 2015

  • Adding AlarmCallbackHistory entity plus service
  • Recording status (success or error) of alarm callbacks including possible error message in AlertScannerThread
@dennisoelkers dennisoelkers added this to the 1.2.0 milestone Jul 21, 2015
@dennisoelkers dennisoelkers force-pushed the feature-alarmcallback-history branch from aeb6a46 to 767b9e6 Jul 23, 2015
@edmundoa edmundoa self-assigned this Jul 27, 2015
import java.util.List;

@RequiresAuthentication
@Api(value = "AlarmCallbacks", description = "Manage stream alarm callback histories")

This comment has been minimized.

@edmundoa

edmundoa Jul 27, 2015
Member

Shouldn't it be called AlarmCallbackHistory? Sharing the name with AlarmCallbacks is confusing, specially on swagger.

This comment has been minimized.

@dennisoelkers

dennisoelkers Jul 27, 2015
Author Member

Of course! :)

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jul 27, 2015

Other than the name change, it looks good to me 👍

@dennisoelkers dennisoelkers force-pushed the feature-alarmcallback-history branch from 2710438 to 241bae0 Jul 29, 2015
edmundoa added a commit that referenced this pull request Jul 30, 2015
Feature: Alarmcallback History
@edmundoa edmundoa merged commit c6869c4 into master Jul 30, 2015
2 checks passed
2 checks passed
ci Jenkins build graylog2-server-integration-pr 92 has succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@edmundoa edmundoa deleted the feature-alarmcallback-history branch Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.