Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Alarmcallback History #1313

Merged
merged 19 commits into from Jul 30, 2015
Merged

Feature: Alarmcallback History #1313

merged 19 commits into from Jul 30, 2015

Conversation

dennisoelkers
Copy link
Member

  • Adding AlarmCallbackHistory entity plus service
  • Recording status (success or error) of alarm callbacks including possible error message in AlertScannerThread

@dennisoelkers dennisoelkers added this to the 1.2.0 milestone Jul 21, 2015
@edmundoa edmundoa self-assigned this Jul 27, 2015
import java.util.List;

@RequiresAuthentication
@Api(value = "AlarmCallbacks", description = "Manage stream alarm callback histories")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be called AlarmCallbackHistory? Sharing the name with AlarmCallbacks is confusing, specially on swagger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! :)

@edmundoa
Copy link
Contributor

Other than the name change, it looks good to me 👍

edmundoa added a commit that referenced this pull request Jul 30, 2015
@edmundoa edmundoa merged commit c6869c4 into master Jul 30, 2015
@edmundoa edmundoa deleted the feature-alarmcallback-history branch July 30, 2015 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants