New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Alarmcallback History #1313
Conversation
dennisoelkers
commented
Jul 21, 2015
- Adding AlarmCallbackHistory entity plus service
- Recording status (success or error) of alarm callbacks including possible error message in AlertScannerThread
aeb6a46
to
767b9e6
Compare
import java.util.List; | ||
|
||
@RequiresAuthentication | ||
@Api(value = "AlarmCallbacks", description = "Manage stream alarm callback histories") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be called AlarmCallbackHistory
? Sharing the name with AlarmCallbacks
is confusing, specially on swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! :)
Other than the name change, it looks good to me 👍 |
This reverts commit fb4c38b.
2710438
to
241bae0
Compare
Feature: Alarmcallback History