Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Transport added Support for SSL Client Authentication #1357

Closed
wants to merge 6 commits into from

Conversation

@gbu-censhare
Copy link
Contributor

@gbu-censhare gbu-censhare commented Aug 16, 2015

The promised new pull request Including TestCases,

Only Supported Key Format is PKCS8, to Provide a Parser vor PKCS1 one should include BountyCastle Crypto Extensions.

"Please use Guava's Joiner instead of implementing this yourself." -> Guava's Joiner doesn't support Enumerations.

Best, Georg

@gbu-censhare
Copy link
Contributor Author

@gbu-censhare gbu-censhare commented Aug 17, 2015

just merged your changes is, my local build is still working.

@joschi
Copy link
Contributor

@joschi joschi commented Aug 17, 2015

@gbu-censhare In this case the build is failing because the source files you've added don't have the expected license header. Just run mvn license:format and they'll be added automatically.

@gbu-censhare
Copy link
Contributor Author

@gbu-censhare gbu-censhare commented Aug 17, 2015

ah, thanks, license header added :)

@joschi joschi added this to the 1.2.0 milestone Aug 20, 2015
bernd added a commit that referenced this pull request Aug 21, 2015
Supplemental changes for PR #1357
@bernd
Copy link
Member

@bernd bernd commented Aug 21, 2015

Closing this in favor of #1363. Thank you very much!

@bernd bernd closed this Aug 21, 2015
@gbu-censhare
Copy link
Contributor Author

@gbu-censhare gbu-censhare commented Aug 21, 2015

Thanks, my pleasure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.