Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling TLS certificate check in REST client #1393

Merged
merged 2 commits into from Sep 3, 2015

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Sep 3, 2015

AsyncHttpClient is verifying SSL server certificates since version 1.9.x. Previous versions did also accept untrusted/unknown certificates.

This PR adds a configuration option to configure the behavior, with the pre-1.9.x behavior being default.

@joschi joschi added this to the 1.2.0 milestone Sep 3, 2015
joschi pushed a commit to graylog-labs/graylog2-web-interface that referenced this pull request Sep 3, 2015
@bernd bernd self-assigned this Sep 3, 2015
@bernd
Copy link
Member

@bernd bernd commented Sep 3, 2015

Tested without REST TLS, with self-signed REST TLS and with an "official" certificate.

LGTM 👍

bernd added a commit that referenced this pull request Sep 3, 2015
Allow disabling TLS certificate check in REST client
@bernd bernd merged commit 6c753f9 into 1.2 Sep 3, 2015
3 checks passed
3 checks passed
ci Jenkins build graylog2-server-integration-pr 214 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the rest-client-certificate-check branch Sep 3, 2015
leusonmario pushed a commit to leusonmario/graylog2-server that referenced this pull request Aug 2, 2017
This respects excluded fields.

Fixes Graylog2#1393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants