Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
joschi
added some commits
Sep 3, 2015
joschi
added
bug
ready-for-review
labels
Sep 3, 2015
joschi
added this to the 1.2.0 milestone
Sep 3, 2015
added a commit
to graylog-labs/graylog2-web-interface
that referenced
this pull request
Sep 3, 2015
joschi
referenced this pull request
Sep 3, 2015
Merged
Add configuration option to disable certificate checks in REST client #1591
bernd
self-assigned this
Sep 3, 2015
This comment has been minimized.
This comment has been minimized.
|
Tested without REST TLS, with self-signed REST TLS and with an "official" certificate. LGTM |
added a commit
that referenced
this pull request
Sep 3, 2015
bernd
merged commit 6c753f9
into
1.2
Sep 3, 2015
bernd
deleted the
rest-client-certificate-check
branch
Sep 3, 2015
pushed a commit
to leusonmario/graylog2-server
that referenced
this pull request
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
joschi commentedSep 3, 2015
AsyncHttpClient is verifying SSL server certificates since version 1.9.x. Previous versions did also accept untrusted/unknown certificates.
This PR adds a configuration option to configure the behavior, with the pre-1.9.x behavior being default.