Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if group lookup worked to avoid a NPE #1491

Merged
merged 1 commit into from Oct 19, 2015
Merged

Check if group lookup worked to avoid a NPE #1491

merged 1 commit into from Oct 19, 2015

Conversation

@bernd
Copy link
Member

@bernd bernd commented Oct 19, 2015

The group lookup can fail if the group belongs to a different domain and the connection user is not allowed to lookup details.

Log a message to DEBUG if the lookup failed to make this debuggable.

Fixes #1453

The group lookup can fail if the group belongs to a different domain and
the connection user is not allowed to lookup details.

Log a message to DEBUG if the lookup failed to make this debuggable.

Fixes #1453
@bernd bernd added this to the 1.2.2 milestone Oct 19, 2015
@joschi joschi added bug users labels Oct 19, 2015
@joschi
Copy link
Contributor

@joschi joschi commented Oct 19, 2015

LGTM. 👍

I'm still unhappy that we don't have any tests for this LDAP stuff. 😢

joschi added a commit that referenced this pull request Oct 19, 2015
Check if LDAP group lookup worked to avoid a NPE
@joschi joschi merged commit 81c5baf into 1.2 Oct 19, 2015
3 checks passed
3 checks passed
ci Jenkins build graylog2-server-integration-pr 287 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@joschi joschi deleted the issue-1453 branch Oct 19, 2015
@joschi joschi self-assigned this Oct 19, 2015
@joschi joschi added the ldap label Oct 19, 2015
joschi added a commit that referenced this pull request Oct 19, 2015
Check if LDAP group lookup worked to avoid a NPE

(cherry picked from commit 81c5baf, refs #1453)
joschi added a commit that referenced this pull request Oct 19, 2015
Check if LDAP group lookup worked to avoid a NPE
(cherry picked from commit 81c5baf, refs #1453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.