New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ES index and mapping creation in Indices#create() #1563

Merged
merged 1 commit into from Nov 20, 2015

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Nov 16, 2015

When creating an Elasticsearch index and putting the respective mapping in separate operations, the mapping creation might fail (e. g. due to a timeout) and lead to invalid messages being indexed into Elasticsearch (e. g. with a wrong type for "timestamp" or other important message fields). Merging these operations should at least solve some of those error situations.

Refs #1502

Merge ES index and mapping creation in Indices#create()
When creating an Elasticsearch index and putting the respective mapping in separate
operations, the mapping creation might fail (e. g. due to a timeout) and lead to
invalid messages being indexed into Elasticsearch (e. g. with a wrong type for "timestamp"
or other important message fields). Merging these operations should at least solve
some of those error situations.

@joschi joschi added this to the 1.2.3 milestone Nov 16, 2015

@bernd bernd self-assigned this Nov 20, 2015

@bernd

This comment has been minimized.

Member

bernd commented Nov 20, 2015

LGTM 👍

bernd added a commit that referenced this pull request Nov 20, 2015

Merge pull request #1563 from Graylog2/index-mapping
Merge ES index and mapping creation in Indices#create()

@bernd bernd merged commit c00868f into 1.2 Nov 20, 2015

3 checks passed

ci Jenkins build graylog2-server-integration-pr 362 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the index-mapping branch Nov 20, 2015

@bernd bernd referenced this pull request Nov 20, 2015

Closed

[put-mapping] can timeout #1502

@joschi joschi modified the milestones: 1.2.3, 1.3.0 Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment