Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to AMQP transports to bind the queue to the exchange #1633

Merged
merged 1 commit into from Dec 15, 2015
Merged

Conversation

@bernd
Copy link
Member

@bernd bernd commented Dec 15, 2015

This was missing before and the exchange and routing-key options were not used.

The binding option defaults to "false" to avoid existing setups to fail when the given exchange (there is a default) does not exist.

Fixes #1599

@bernd bernd added this to the 1.3.1 milestone Dec 15, 2015
@@ -292,6 +294,15 @@ public ConfigurationRequest getRequestedConfiguration() {
);

cr.addField(
new BooleanField(
CK_EXCHANGE_BIND,
"Bind to exchange?",
Copy link
Contributor

@joschi joschi Dec 15, 2015

Is this a question? 😉

This was missing before and the exchange and routing-key options were
not used.

The binding option defaults to "false" to avoid existing setups to fail
when the given exchange (there is a default) does not exist.

Fixes #1599
@bernd
Copy link
Member Author

@bernd bernd commented Dec 15, 2015

I updated the wording for the config options.

@joschi
Copy link
Contributor

@joschi joschi commented Dec 15, 2015

LGTM. 👍

joschi added a commit that referenced this issue Dec 15, 2015
Add option to AMQP transports to bind the queue to the exchange
@joschi joschi merged commit ded6a5a into 1.3 Dec 15, 2015
0 of 3 checks passed
@joschi joschi deleted the issue-1599 branch Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants