New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard Message Output for Graylog2 1.3 #1688

Merged
merged 1 commit into from Jan 12, 2016

Conversation

Projects
None yet
4 participants
@henrikjohansen

henrikjohansen commented Jan 12, 2016

I have butchered the Benchmark Output into something that simply discards messages - the rationale behind that is documented here :

https://medium.com/@henrikjohansen/graylog2-forwarder-nodes-5ec5e4f97e21#.yptnbrtv0

Please consider adding this to the 1.3 branch :)

Henrik Johansen

@joschi joschi added the outputs label Jan 12, 2016

@joschi joschi added this to the 1.3.3 milestone Jan 12, 2016

@joschi joschi self-assigned this Jan 12, 2016

journal.markJournalOffsetCommitted(maxOffset);
}
public interface Factory extends MessageOutput.Factory<GelfOutput> {

This comment has been minimized.

@joschi

joschi Jan 12, 2016

Contributor

This should rather be typed to DiscardMessageOutput instead of GelfOutput (same for the create method).

@joschi

This comment has been minimized.

Contributor

joschi commented Jan 12, 2016

I'll fix the return types in DiscardMessageOutput.Factory after merging and add a simple metric of the number of discarded messages after merging.

Thanks!

joschi added a commit that referenced this pull request Jan 12, 2016

Merge pull request #1688 from henrikjohansen/1.3
Add Discard Message Output

@joschi joschi merged commit e2ae28a into Graylog2:1.3 Jan 12, 2016

1 of 2 checks passed

ci Jenkins build graylog2-server-integration-pr 496 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

joschi added a commit that referenced this pull request Jan 12, 2016

joschi added a commit that referenced this pull request Jan 12, 2016

joschi added a commit that referenced this pull request Jan 12, 2016

Merge pull request #1688 from henrikjohansen/1.3
Add Discard Message Output
(refs #1688, cherry picked from commit e2ae28a)

joschi added a commit that referenced this pull request Jan 12, 2016

joschi added a commit that referenced this pull request Jan 12, 2016

@razvanphp

This comment has been minimized.

Contributor

razvanphp commented Jan 21, 2016

Just to be clear, can we use this in a graylog server without any ES connected to it?

Would it be something like a forwarder to another graylog server (that does the storage instead) ?

@kroepke

This comment has been minimized.

Member

kroepke commented Jan 21, 2016

Yes, that is one use case for it. Another one could be to run benchmarks having to have storage attached, although we do ship with a benchmark output that writes timings and counts to a CSV file. However if you don't want that you could use this output.

@razvanphp

This comment has been minimized.

Contributor

razvanphp commented Jan 22, 2016

Well how do we launch it? It's not present in graylog-web 1.3.3, I can only choose GELF Output and STDOUT Output.

@joschi

This comment has been minimized.

Contributor

joschi commented Jan 22, 2016

@razvanphp This message output is supposed to replace the default output (see https://github.com/Graylog2/graylog2-server/blob/1.3.3/graylog2-server/src/main/java/org/graylog2/Configuration.java#L131-L132) and not to be used as a stream output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment