Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation_date key. #1693

Closed

Conversation

@macfergus
Copy link

@macfergus macfergus commented Jan 14, 2016

I think this will fix #725, in which the index is always rotated at startup when you're using TimeBasedRotationStrategy.

The settings key was wrong, so the creation_date always came up as 0L, which indicated that the index was overdue for rotation. Tested this patch in our setup and it works like a champ.

The correct key is index.creation_date.
joschi pushed a commit that referenced this pull request Jan 15, 2016
Fixes #725, closes #1693
@joschi joschi closed this in 30cc994 Jan 15, 2016
@joschi
Copy link
Contributor

@joschi joschi commented Jan 15, 2016

Thanks! I've corrected the used index settings key and added some tests to avoid regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants