Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix creation_date key. #1693
Conversation
added a commit
that referenced
this pull request
Jan 15, 2016
joschi
closed this
in
30cc994
Jan 15, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks! I've corrected the used index settings key and added some tests to avoid regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
macfergus commentedJan 14, 2016
I think this will fix #725, in which the index is always rotated at startup when you're using TimeBasedRotationStrategy.
The settings key was wrong, so the creation_date always came up as 0L, which indicated that the index was overdue for rotation. Tested this patch in our setup and it works like a champ.