Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kafka 0.9.0.1 #1912

Merged
merged 2 commits into from Jun 3, 2016
Merged

Upgrade to Kafka 0.9.0.1 #1912

merged 2 commits into from Jun 3, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Mar 8, 2016

This PR upgrades Graylog to the latest version of Apache Kafka.

@kroepke
Copy link
Member

@kroepke kroepke commented Apr 1, 2016

I'd like to push this out after 2.0 GA so we can stresstest our journal implementation with the updated version.

@bernd bernd added this to the 2.1.0 milestone Apr 1, 2016
@joschi joschi force-pushed the kafka-0.9.0 branch from 5eba44c to 34421e6 Apr 23, 2016
metricRegistry.register(name(KafkaJournal.class, "unflushedMessages"), (Gauge<Long>) kafkaLog::unflushedMessages);
metricRegistry.register(name(KafkaJournal.class, "recoveryPoint"), (Gauge<Long>) kafkaLog::recoveryPoint);
metricRegistry.register(name(KafkaJournal.class, "lastFlushTime"), (Gauge<Long>) kafkaLog::lastFlushTime);
metricRegistry.register(GlobalMetricNames.JOURNAL_OLDEST_SEGMENT, (Gauge<Date>) () -> {

This comment has been minimized.

@kroepke

kroepke Jun 3, 2016
Member

For some reason I get the following in the metrics browser:

 org.graylog2.journal.oldest-segment
Kafkajournal$$lambda$16/1566269351
Invalid metric type: Kafkajournal$$lambda$16/1566269351

This comment has been minimized.

@kroepke

kroepke Jun 3, 2016
Member

This works when using an anonymous class. Apparently the Jackson serialization doesn't properly go through lambdas here.

@kroepke kroepke force-pushed the kafka-0.9.0 branch from 34421e6 to ef74168 Jun 3, 2016
@kroepke
Copy link
Member

@kroepke kroepke commented Jun 3, 2016

lgtm, @joschi please have a look at the commit i added

@kroepke kroepke self-assigned this Jun 3, 2016
@kroepke kroepke merged commit 8162ade into master Jun 3, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 966 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 453 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kroepke kroepke deleted the kafka-0.9.0 branch Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.