New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert annotations #1921

Merged
merged 10 commits into from Mar 11, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Mar 11, 2016

Add alert annotations back to the search histogram with some changes:

  • Global search will show alerts for all streams, just as before
  • Stream search will only show alerts for the current stream
  • Alerts will refresh along with the rest of the search page, when using the refresh search button

@edmundoa edmundoa added the web label Mar 11, 2016

@edmundoa edmundoa added this to the 2.0.0 milestone Mar 11, 2016

@dennisoelkers dennisoelkers self-assigned this Mar 11, 2016

},
_getAlertAnnotation(alert) {
const stream = this.streams.filter(s => s.id === alert.stream_id)[0];

This comment has been minimized.

@dennisoelkers

dennisoelkers Mar 11, 2016

Member

A check if this.streams is defined already is required here.

dennisoelkers added a commit that referenced this pull request Mar 11, 2016

@dennisoelkers dennisoelkers merged commit 867b7d7 into master Mar 11, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 732 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 222 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the alert-annotations branch Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment