Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading web interface assets also handle jar URIs #1930

Merged
merged 3 commits into from Mar 15, 2016
Merged

When loading web interface assets also handle jar URIs #1930

merged 3 commits into from Mar 15, 2016

Conversation

@kroepke
Copy link
Member

@kroepke kroepke commented Mar 15, 2016

After assembly we cannot use File objects to access individual asset files. Instead we need to use a JarFileSystem to access the file metadata.

We could also cache the etag and modification dates in case of jars, but this change currently does not do that. We may want to revisit this in the future.
The patch uses a LoadingCache as a simple "lock" when creating the filesystem (uris will overlap and reference mostly the shaded jar, the cache makes sure only one thread is creating the filesystem).

fix #1924

After assembly we cannot use File objects to access individual asset files. Instead we need to use a JarFileSystem to access the file metadata.

We could also cache the etag and modification dates in case of jars, but this change currently does not do that. We may want to revisit this in the future.
The patch uses a LoadingCache as a simple "lock" when creating the filesystem (uris will overlap and reference mostly the shaded jar, the cache makes sure only one thread is creating the filesystem).

fix #1924
kroepke and others added 2 commits Mar 15, 2016
previously assets didn't have appropriate cache headers when coming from plugins
Also catch FileSystemAlreadyExistsException in cache loader.
bernd added a commit that referenced this issue Mar 15, 2016
When loading web interface assets also handle jar URIs
@bernd bernd merged commit 694ad19 into master Mar 15, 2016
0 of 4 checks passed
@bernd bernd deleted the issue-1924 branch Mar 15, 2016
@lennartkoopmann
Copy link
Member

@lennartkoopmann lennartkoopmann commented Mar 15, 2016

Thanks! 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants