New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PID file earlier in the startup process #1978

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Mar 24, 2016

The PID file of the Graylog server process is created rather late in the startup process (e. g. after the Guice injector has been created). If an error happened before but didn't shutdown the Graylog server process, the PID file might not have been created although the process keeps running which in turn might cause problems with external process monitors.

This PR moves the creation of the PID file to the earliest sensible moment in the startup process of Graylog.

Fixes #1969

@joschi joschi added this to the 2.0.0 milestone Mar 24, 2016

@bernd bernd self-assigned this Mar 29, 2016

@bernd

This comment has been minimized.

Member

bernd commented Mar 29, 2016

LGTM 👍

@bernd bernd merged commit 96d039d into master Mar 29, 2016

2 of 4 checks passed

ci-server-integration Jenkins build is being scheduled
Details
ci-web-linter Jenkins build is being scheduled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the issue-1969 branch Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment