New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable shutdown hooks for log4j #2015

Merged
merged 1 commit into from Apr 1, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Apr 1, 2016

once we stop the process is going to exit anyway, so there's no real use in unregistering logger context mbeans etc.
this might change if we ever wanted to support unloading plugins, but that's so much more work than just this, we might as well fix the exceptions during shutdown the easy way

fix #1795

disable shutdown hooks for log4j
once we stop the process is going to exit anyway, so there's no real use in unregistering logger context mbeans etc.
this might change if we ever wanted to support unloading plugins, but that's so much more work than just this, we might as well fix the exceptions during shutdown the easy way
@bernd

This comment has been minimized.

Member

bernd commented Apr 1, 2016

LGTM 👍

@bernd bernd merged commit 56a4bb7 into master Apr 1, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 783 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 272 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the log4j-shutdown-hooks branch Apr 1, 2016

@bernd bernd added this to the 2.0.0 milestone Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment