Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace message field analysers dropdown #2023

Merged
merged 1 commit into from Apr 12, 2016
Merged

Replace message field analysers dropdown #2023

merged 1 commit into from Apr 12, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Apr 4, 2016

Improve usability of selecting field analysers by replacing the drop-down with a collapsible panel. The main advantage of this change is that it avoids scrolling inside the search sidebar when the number of fields is small and there's space on the screen.

Fixes #2022.

Improve usability of selecting field analyzers by replacing the dropdown
with a collapsible panel.

Fixes #2022
@edmundoa edmundoa added the web label Apr 4, 2016
@edmundoa edmundoa added this to the 2.0.0 milestone Apr 4, 2016
@dennisoelkers dennisoelkers self-assigned this Apr 11, 2016
@bernd
Copy link
Member

@bernd bernd commented Apr 12, 2016

Not sure if this is supposed to be fixed, but I still have to scroll in the side bar.

screenshot from 2016-04-12 17 09 54

Maybe I got your description wrong and that cannot be avoided.

@bernd bernd assigned bernd and unassigned dennisoelkers Apr 12, 2016
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Apr 12, 2016

You cannot avoid scrolling when there is no space at the bottom. But you can avoid it when the sidebar can expand. This is what shouldn't happen:

screen shot 2016-04-12 at 17 15 17

In that case, the sidebar does not get to the bottom of the page, but the dropdown is still hidden, making you scroll when there is no need for it. The panel version will actually increase the sidebar height, allowing you to see all options without any further action.

This is specially annoying when you have three or four fields, as you will have to scroll all the time when using dropdowns.

@bernd
Copy link
Member

@bernd bernd commented Apr 12, 2016

Thanks for the explanation! 😃

@bernd
Copy link
Member

@bernd bernd commented Apr 12, 2016

LGTM 👍

@bernd bernd merged commit 8edcf3b into master Apr 12, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 793 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 282 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the issue-2022 branch Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants