New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions using custom events from SearchStore #2067

Merged
merged 1 commit into from Apr 13, 2016

Conversation

Projects
None yet
3 participants
@edmundoa
Member

edmundoa commented Apr 12, 2016

We added events to the SearchStore when only part of our code was React, and everything was disconnected. Now we don't need them any more, and they are source of some troubles since we made the stores global. In this commit I'm changing our current code to directly use the SearchStore.

By the way, the issue reported in #2040 (and other issues with the custom events used before this PR) is only visible when running in production mode, at least I couldn't reproduce it with webpack-dev-server.

Fixes #2040

Fix actions using custom events from SearchStore
We added events to the SearchStore when only part of our code was React,
and everything was disconnected. Now we don't need them any more, and
they are source of some troubles since we made the stores global. In
this commit I'm changing our current code to directly use the
SearchStore.

Fixes #2040

@edmundoa edmundoa added this to the 2.0.0 milestone Apr 12, 2016

@kroepke

This comment has been minimized.

Member

kroepke commented Apr 13, 2016

lgtm

@kroepke kroepke merged commit 40843a4 into master Apr 13, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 818 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 307 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kroepke kroepke deleted the issue-2040 branch Apr 13, 2016

@alekc

This comment has been minimized.

alekc commented Apr 13, 2016

Is there any ETA for this patch going live? It's the only missing feature which stops me from sending beta in production.

@edmundoa

This comment has been minimized.

Member

edmundoa commented Apr 13, 2016

It is going into beta.3, probably out later today or tomorrow.

@alekc

This comment has been minimized.

alekc commented Apr 13, 2016

Ok great.
Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment