New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "." in message field keys with a "_" for ES >=2.0 compatibility #2078

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
3 participants
@bernd
Member

bernd commented Apr 14, 2016

The replacement character is currently hard coded to "_". If the transformed key already exists, we drop the field.

This reverts the Message parts of d07f06f.

@bernd bernd added this to the 2.0.0 milestone Apr 14, 2016

@joschi joschi self-assigned this Apr 14, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Apr 14, 2016

LGTM. 👍

Replace "." in message field keys with a "_" for ES >=2.0 compatibility
The replacement character is currently hard coded to "_". If the
transformed key already exists, we drop the field.

This reverts the Message parts of d07f06f.

@bernd bernd force-pushed the replace-dot-key branch from c1bdfc2 to 3953af2 Apr 14, 2016

@joschi joschi merged commit cf8fdc7 into master Apr 14, 2016

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci-server-integration Jenkins build graylog2-server-integration-pr 828 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 316 has succeeded
Details

@joschi joschi deleted the replace-dot-key branch Apr 14, 2016

@vladimirfx

This comment has been minimized.

vladimirfx commented Apr 16, 2016

GELF spec clearly states that dot is valid character. This fix is data loss because of conflicting keys is just removed. With this "fix" data completeness is depended on runtime field set. Consider using other delimiter (eg double "_") as replacement separator or make it configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment