New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return deflector indices in Deflector#getAllDeflectorIndices() #2100

Merged
merged 2 commits into from Apr 18, 2016

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Apr 18, 2016

Unbreaks count based index retention (again).

Also rename #getAllDeflectorIndexNames() to #getAllIndexNames() for clarity.

Only return deflector indices in Deflector#getAllDeflectorIndices()
Unbreaks count based index retention (again).

Also rename #getAllDeflectorIndexNames() to #getAllIndexNames() for
clarity.

@bernd bernd added this to the 2.0.0 milestone Apr 18, 2016

@joschi joschi self-assigned this Apr 18, 2016

*
* @return list of managed indices
*/
public String[] getAllIndexNames() {

This comment has been minimized.

@joschi

joschi Apr 18, 2016

Contributor

Minor nitpick: Maybe getAllGraylogIndexNames would be more specific (and would also match isGraylogIndex).

This comment has been minimized.

@bernd

bernd Apr 18, 2016

Member

Aye, good point. Renamed to getAllGraylogIndexNames and getAllGraylogDeflectorIndices.

@joschi

This comment has been minimized.

Contributor

joschi commented Apr 18, 2016

LGTM. 👍

@joschi joschi merged commit 7d2c0ca into master Apr 18, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci-server-integration Jenkins build graylog2-server-integration-pr 842 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 330 has succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the fix-index-retention branch Apr 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment