Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TCP keepalive setting into AbstractTcpTransport #2112

Merged
merged 1 commit into from Apr 20, 2016
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Apr 20, 2016

All kinds of TCP transports might profit from using TCP keepalive, not just line-based TCP transports (which are implemented by TcpTransport).

All kinds of TCP transports might profit from using TCP keepalive,
not just line-based TCP transports (which are implemented by TcpTransport).
@joschi joschi added this to the 2.0.0 milestone Apr 20, 2016
@kroepke
Copy link
Member

@kroepke kroepke commented Apr 20, 2016

lgtm 👍

@kroepke kroepke merged commit f6629ef into master Apr 20, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 848 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 336 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kroepke kroepke deleted the tcp-keepalive branch Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants