Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default values in plugable entities forms #2122

Merged
merged 1 commit into from Apr 21, 2016
Merged

Include default values in plugable entities forms #2122

merged 1 commit into from Apr 21, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Apr 21, 2016

Changes in #2114 caused another issue with the pluggable entities forms: default values were shown in forms, but never submitted to the server.

These changes move the logic taking care of default values to the ConfigurationForm component, also removing incorrect uses of defaultValue in inputs.

In this way, the object containing the data will contain the default values at the beginning, and they will be overriden by any input the user type in them.

Fixes #2108, this time hopefully in the right way 馃槃

Changes in #2114 caused another issue with the pluggable entities forms:
default values were shown in forms, but never submitted to the server.

These changes move the logic taking care of default values to the
`ConfigurationForm` component, also removing incorrect uses of
`defaultValue` in inputs.

In this way, the object containing the data will contain the default
values at the beginning, and they will be overriden by any input the
user type in them.

Refs #2108
@edmundoa edmundoa added this to the 2.0.0 milestone Apr 21, 2016
@bernd bernd self-assigned this Apr 21, 2016
@bernd
Copy link
Member

@bernd bernd commented Apr 21, 2016

Tested, fixes the issue. 馃憤

@bernd bernd merged commit d191cd5 into master Apr 21, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 854 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 342 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the issue-2108 branch Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.