Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore empty authentication tokens in LdapUserAuthenticator #2123

Merged
merged 1 commit into from Apr 21, 2016
Merged

Conversation

@kroepke
Copy link
Member

@kroepke kroepke commented Apr 21, 2016

unauthenticated requests and requests which use sessions in the URL rather than via HTTP headers can have a null UsernamePasswordToken associated with them
The Ldap authenticator didn't check for null values before looking up the account, which lead to a harmless, but noisy exception which was not logged in previous versions

add null checks before use the token

fixes #2111

@kroepke kroepke added this to the 2.0.0 milestone Apr 21, 2016
unauthenticated requests and requests which use sessions in the URL rather than via HTTP headers can have a null UsernamePasswordToken associated with them
The Ldap authenticator didn't check for null values before looking up the account, which lead to a harmless, but noisy exception which was not logged in previous versions

add null checks before use the token

fixes #2111
@bernd bernd self-assigned this Apr 21, 2016
@bernd
Copy link
Member

@bernd bernd commented Apr 21, 2016

LGTM 👍

@bernd bernd mentioned this pull request Apr 21, 2016
@bernd bernd merged commit 2c42fee into master Apr 21, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 855 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 343 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the issue-2111 branch Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.