Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display not found page #2139

Merged
merged 1 commit into from Apr 26, 2016
Merged

Display not found page #2139

merged 1 commit into from Apr 26, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Apr 25, 2016

This adds the 404 page back when the route doesn't match another component. In the end I'm sending the "funny" in the PR. The image is under a Creative Commons Zero license, so don't think there is any problem using it: http://gratisography.com/terms.html

We can also ship a more serious version if necessary 馃槃

@edmundoa edmundoa added this to the 2.0.0 milestone Apr 25, 2016
@bernd bernd self-assigned this Apr 26, 2016
@bernd
Copy link
Member

@bernd bernd commented Apr 26, 2016

I like the funny 404 page. Any other opinions? @dennisoelkers @joschi @kroepke @lennartkoopmann @mariussturm

Loading

@joschi
Copy link
Contributor

@joschi joschi commented Apr 26, 2016

I like the funny image but can we make it a little bit smaller? I find ~500 KB and 1836x1224 pixels a little too much鈥

Loading

@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Apr 26, 2016

@joschi I will try, in the end it depends on how it affects the image quality. The original is 5MB so getting it down to 500KB was already a big weight loss 馃槃

Loading

@bernd
Copy link
Member

@bernd bernd commented Apr 26, 2016

LGTM 馃憤

Loading

@bernd bernd merged commit 2d993ac into master Apr 26, 2016
0 of 4 checks passed
Loading
@bernd bernd deleted the 404-page branch Apr 26, 2016
bernd added a commit that referenced this issue Apr 26, 2016
(cherry picked from commit 2d993ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants