Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid wildcard host ( in rest_transport_uri #2205

merged 1 commit into from May 9, 2016


Copy link

@joschi joschi commented May 9, 2016

It's a common error for users to set rest_transport_uri to despite the documentation and comments advising not to.

The change in this PR explicitly checks that rest_transport_uri is in fact not the wildcard address, issues a warning if it is being used anyway, and falls back to the default transport address in this case.

@joschi joschi added this to the 2.0.1 milestone May 9, 2016
@dennisoelkers dennisoelkers self-assigned this May 9, 2016
@dennisoelkers dennisoelkers merged commit 4f7459d into 2.0 May 9, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 890 has succeeded
ci-web-linter Jenkins build graylog-pr-linter-check 378 has succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@dennisoelkers dennisoelkers deleted the rest_transport_uri-wildcard branch May 9, 2016
dennisoelkers added a commit that referenced this pull request May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants