New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness for unreachable nodes #2206

Merged
merged 6 commits into from May 10, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented May 9, 2016

Before this change, some pages were not loading when at least one node in the cluster was unreachable. With this change, information from reachable nodes is shown. Additionally, an error similar to the 404 page was created, which shows failed requests for pages which do not make sense to show at all when a node is not reachable.

@dennisoelkers dennisoelkers added this to the 2.0.1 milestone May 9, 2016

@edmundoa edmundoa self-assigned this May 10, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented May 10, 2016

I did some small word changes in the new error page. The rest looks good to me 👍

@edmundoa edmundoa merged commit a1dbc51 into master May 10, 2016

0 of 4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 898 is running
Details
ci-web-linter Jenkins build is being scheduled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@edmundoa edmundoa deleted the improve-robustness-for-unreachable-nodes branch May 10, 2016

edmundoa added a commit that referenced this pull request May 10, 2016

Improve robustness for unreachable nodes (#2206)
* Check for null values in response maps.

* Fixing linter hints.

* Make `SystemJobsComponent` resilient against unreachable nodes.

* Showing error instead of spinners for overview of unreachable node.

* Make logging page resilient against unreachable nodes.

* Change a bit the wording of PageErrorOverview

(cherry picked from commit a1dbc51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment