Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search with no results page #2253

Merged
merged 6 commits into from May 25, 2016
Merged

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented May 18, 2016

This PR adds some actions to the page rendered when searches do not have any results. After the changes, these actions are available:

  • Add count to dashboard
  • Add histogram to dashboard
  • Save search, or update/delete saved search if search was already saved

I also worked a bit in some texts, and reformatted the affected components.

Fixes graylog-labs/graylog2-web-interface#1639, and graylog-labs/graylog2-web-interface#1158.

@edmundoa edmundoa added the web label May 18, 2016
@edmundoa edmundoa added this to the 2.1.0 milestone May 18, 2016
@dennisoelkers dennisoelkers self-assigned this May 18, 2016
@dennisoelkers dennisoelkers merged commit 63779ef into master May 25, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 908 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 396 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dennisoelkers dennisoelkers deleted the improve-no-results-page branch May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants