New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics improvements #2255

Merged
merged 3 commits into from May 26, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented May 18, 2016

While looking into #2250, I found a couple of issues with the metrics page:

  • Doing a full page refresh on the metrics page raised an exception, as MetricsStore.name() was being called before the store had initialised the node list
  • Writing an invalid regex in the metrics filter would raise an exception, and also break the page

This PR fixes those two issues, and also updates the filters to node buffers.

edmundoa added some commits May 18, 2016

Avoid fetching metrics before node list is loaded
- ShowMetricsPage listens to NodesStore to get the metrics
- MetricsStore.names() adds a warning in the console if the list of
  nodes is not yet available
Catch exceptions on metrics filter regex
Also show a message when no metrics match the filter or the filter is
invalid.

@edmundoa edmundoa modified the milestones: 2.1.0, 2.0.2 May 18, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented May 18, 2016

I based the changes on master, but they should also be included in 2.0.2. Please let me know if there's any conflict doing so. Thank you!

@dennisoelkers dennisoelkers self-assigned this May 24, 2016

@dennisoelkers dennisoelkers merged commit bf4964b into master May 26, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 909 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 397 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the metrics-improvements branch May 26, 2016

dennisoelkers added a commit that referenced this pull request May 26, 2016

Metrics improvements (#2255)
* Avoid fetching metrics before node list is loaded

- ShowMetricsPage listens to NodesStore to get the metrics
- MetricsStore.names() adds a warning in the console if the list of
  nodes is not yet available

* Catch exceptions on metrics filter regex

Also show a message when no metrics match the filter or the filter is
invalid.

* Update buffer metrics filter

Fixes #2250

(cherry picked from commit bf4964b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment