Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with old dashboards #2262

Merged
merged 3 commits into from May 24, 2016
Merged

Fix issues with old dashboards #2262

merged 3 commits into from May 24, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented May 19, 2016

As I mentioned in #2163, I was able to reproduce two issues with old dashboards:

  • The positions object may not contain width and height for a widget
  • Quick value widgets created before pie charts were introduced will not render neither a data table, nor a pie chart

This PR fixes those two issues (and therefore #2163), and also corrects a typo in the default widget positioning.

The changes should be merged into master as well.

edmundoa added 3 commits May 19, 2016
Quickvalues widgets created before introducing pie charts may not render
neither a data table, nor a pie chart. In this commit we ensure we
always render the data table by default.

Refs #2163
Dashboards created in old Graylog versions may have a positions object
that does not contain widget width or height. Instead of relying on what
that positions object had, this commit ensures each component of the
widget position is initialized with the persisted value or its default.

Refs #2163
@edmundoa edmundoa added this to the 2.0.2 milestone May 19, 2016
@dennisoelkers dennisoelkers merged commit d2fcddb into 2.0 May 24, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 910 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 398 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dennisoelkers dennisoelkers deleted the issue-2163 branch May 24, 2016
dennisoelkers added a commit that referenced this pull request May 24, 2016
* Always render quickvalues data table by default

Quickvalues widgets created before introducing pie charts may not render
neither a data table, nor a pie chart. In this commit we ensure we
always render the data table by default.

Refs #2163

* Fix typo

* Be more picky getting widgets dimensions

Dashboards created in old Graylog versions may have a positions object
that does not contain widget width or height. Instead of relying on what
that positions object had, this commit ensures each component of the
widget position is initialized with the persisted value or its default.

Refs #2163

(cherry picked from commit d2fcddb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants