New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Version class to use com.github.zafarkhaja.semver.Version #2275

Merged
merged 1 commit into from Jun 3, 2016

Conversation

Projects
None yet
3 participants
@joschi
Contributor

joschi commented May 23, 2016

For plugin authors it's currently a little bit cumbersome to use the Version class for various reasons.

This PR refactors the Version class to internally use Java SemVer and adds some helper methods to read the version from the class path.

@joschi joschi added this to the 2.1.0 milestone May 23, 2016

@joschi joschi removed the in progress label May 23, 2016

@kroepke kroepke self-assigned this Jun 3, 2016

@kroepke

This comment has been minimized.

Member

kroepke commented Jun 3, 2016

lgtm

@kroepke kroepke merged commit 987eb80 into Graylog2:master Jun 3, 2016

@joschi joschi deleted the joschi:improve-versions-class branch Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment