New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if props actually contain configuration fields before copying them #2298

Merged
merged 1 commit into from May 30, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented May 27, 2016

This helps against the dropdown breaking because of an unhandled
exception due to a deselected input type and the following nonpresence
of configuration fields in the on change handler.

Should also be merged into master.

Fixes #2297

Check if props actually contain configuration fields before copying them
This helps against the dropdown breaking because of an unhandled
exception due to a deselected input type and the following nonpresence
of configuration fields in the on change handler.

Fixes #2297

@dennisoelkers dennisoelkers added the bug label May 27, 2016

@dennisoelkers dennisoelkers added this to the 2.0.3 milestone May 27, 2016

@edmundoa edmundoa self-assigned this May 30, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented May 30, 2016

LGTM 👍

@edmundoa edmundoa merged commit e316629 into 2.0 May 30, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 933 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 421 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the issue-2297 branch May 30, 2016

edmundoa added a commit that referenced this pull request May 30, 2016

Check if props actually contain configuration fields before copying t…
…hem (#2298)

This helps against the dropdown breaking because of an unhandled
exception due to a deselected input type and the following nonpresence
of configuration fields in the on change handler.

Fixes #2297
(cherry picked from commit e316629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment