New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changes for pipeline processor simulator #2320

Merged
merged 8 commits into from Jun 9, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Jun 1, 2016

These are required changes in common components being used in the first version of the message pipeline processor simulator, in summary:

  • Add prop to LoaderTabs to control whether the loaded message should be display or not
  • Add prop to MessageDetail to disable all links and buttons when showing message simulations
  • Changes in MessageShow to ensure the props it receives are instances of immutable.js objects, so other components using it don't need to care about it
  • Extract transformation of messages from the REST API into the internal object we use to it's own function, making it available in other places of the code

Changes required for Graylog2/graylog-plugin-pipeline-processor#34

@edmundoa edmundoa added the web label Jun 1, 2016

@edmundoa edmundoa added this to the 2.1.0 milestone Jun 1, 2016

@edmundoa edmundoa referenced this pull request Jun 1, 2016

Merged

Pipeline simulator v1 #34

@dennisoelkers dennisoelkers self-assigned this Jun 7, 2016

edmundoa added some commits May 31, 2016

Extract message formatting from UniversalSearchStore
Lets other stores receiving messages to format them in the same way.
Ensure props passed to MessageShow use Immutable.js
As we don't use Immutable.js in new components, convert received props
to not break old components used by MessageShow.
Adapt MessageDetail to display message simulations
Message simulations will not be persisted, so we remove most of the
actions and links, and adapt some texts.
Display string representation of field
When displaying a message, use a string representation of fields. This
allows us to render "true" and "false" values, for instance.
Remove references to simulation
To avoid tying the main component to something that still lives on a
plugin, we remove the `isSimulation` prop, and all references to
simulation.

Instead, we are adding the `disableMessageActions` prop to make possible
to hide the message actions. We also display some text when the message
index is not set, to let the user know that the message is not
persisted.
Use same object to generate message URL
We generate two URLs to the message inside the `MessageDetail`
component, and we should do it in the same way to avoid inconsistencies.

@edmundoa edmundoa force-pushed the simulator branch from bfbada1 to 669e5b9 Jun 8, 2016

possiblyHighlight(fieldName) {
// No highlighting for the message details view.
return this.props.message.fields[fieldName];
return String(this.props.message.fields[fieldName]);
},
render() {
return (
<div className="row content">

This comment has been minimized.

@dennisoelkers

dennisoelkers Jun 9, 2016

Member

Could you replace this with a Row-component?

This comment has been minimized.

@edmundoa
possiblyHighlight(fieldName) {
// No highlighting for the message details view.
return this.props.message.fields[fieldName];
return String(this.props.message.fields[fieldName]);
},
render() {
return (
<div className="row content">
<div className="col-md-12">

This comment has been minimized.

@dennisoelkers

dennisoelkers Jun 9, 2016

Member

Could you replace this with a Col-component?

This comment has been minimized.

@edmundoa

@dennisoelkers dennisoelkers merged commit 7aa7d98 into master Jun 9, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 979 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 465 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the simulator branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment