Calculate keyword from and to values on the fly #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyword time ranges may be in memory for a while, and the range they represent may change over that time. Currently, they are also inconsistent with the way relative ranges work, which are calculated when `getFrom` and `getTo` are called. These changes avoid those two problems by calculating the keyword from and to values when the methods are called. Fixes #2301
|
By the way, to test it I was using a widget created using |
|
LGTM. 👍 |
joschi
pushed a commit
that referenced
this pull request
Jun 9, 2016
Keyword time ranges may be in memory for a while, and the range they represent may change over that time. Currently, they are also inconsistent with the way relative ranges work, which are calculated when `getFrom` and `getTo` are called. These changes avoid those two problems by calculating the keyword from and to values when the methods are called. Fixes #2301 (cherry picked from commit 3c4550a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword time ranges may be in memory for a while, and the range they represent may change over that time. Currently, they are also inconsistent with the way relative ranges work, which are calculated when
getFrom()andgetTo()are called. These changes avoid those two problems by calculating the keyword from and to values when the methods are called.The changes should be merged into master as well.
Fixes #2301.