/graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate keyword from and to values on the fly #2335

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Reviewers
No reviews
Assignees

@joschi joschi

Labels
Projects
None yet
Milestone
  2.0.3
2 participants
@edmundoa @joschi
@edmundoa
Member

edmundoa commented Jun 6, 2016 •
edited

Keyword time ranges may be in memory for a while, and the range they represent may change over that time. Currently, they are also inconsistent with the way relative ranges work, which are calculated when getFrom() and getTo() are called. These changes avoid those two problems by calculating the keyword from and to values when the methods are called.

The changes should be merged into master as well.

Fixes #2301.
@edmundoa
Calculate keyword from and to values on the fly 
Keyword time ranges may be in memory for a while, and the range they
represent may change over that time. Currently, they are also inconsistent
with the way relative ranges work, which are calculated when `getFrom` and
`getTo` are called.

These changes avoid those two problems by calculating the keyword from and
to values when the methods are called.

Fixes #2301
Loading status checks…
acaf618

@edmundoa edmundoa added the ready-for-review label Jun 6, 2016

@edmundoa edmundoa added this to the 2.0.3 milestone Jun 6, 2016

@edmundoa

This comment has been minimized.

Sign in to view
Member

edmundoa commented Jun 6, 2016

By the way, to test it I was using a widget created using last five minutes as keyword search.

@joschi joschi self-assigned this Jun 9, 2016

@joschi

This comment has been minimized.

Sign in to view
Contributor

joschi commented Jun 9, 2016

LGTM. 👍

@joschi joschi merged commit 3c4550a into 2.0 Jun 9, 2016
4 checks passed

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 969 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 456 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the issue-2301 branch Jun 9, 2016

joschi added a commit that referenced this pull request Jun 9, 2016

@edmundoa @joschi
Calculate keyword from and to values on the fly (#2335) 
Keyword time ranges may be in memory for a while, and the range they
represent may change over that time. Currently, they are also inconsistent
with the way relative ranges work, which are calculated when `getFrom` and
`getTo` are called.

These changes avoid those two problems by calculating the keyword from and
to values when the methods are called.

Fixes #2301
(cherry picked from commit 3c4550a)
Loading status checks…
5f7b43c

@kroepke kroepke referenced this pull request Jun 20, 2016

Open

Refactor TimeRange classes #2387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment