New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not init available alarm callback types, fetch them explicitly. #2353

Merged
merged 3 commits into from Jun 15, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jun 14, 2016

When we are fetching the available alarm callback types during init of
AlarmCallbacksStore, we don't have a stream id to fetch for yet.
Therefore we are running into permission problems in the backend
resource for non-admin users. This change replaces the init with an
explicit fetch of available alarm callback types in the consumer.

Fixes #2352

dennisoelkers added some commits Jun 14, 2016

Do not init available alarm callback types, fetch them explicitly.
When we are fetching the available alarm callback types during init of
AlarmCallbacksStore, we don't have a stream id to fetch for yet.
Therefore we are running into permission problems in the backend
resource for non-admin users. This change replaces the init with an
explicit fetch of available alarm callback types in the consumer.

Fixes #2352

@dennisoelkers dennisoelkers added the bug label Jun 14, 2016

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Jun 14, 2016

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Jun 14, 2016

Could/should be merged in 2.0.3 if possible.

@edmundoa edmundoa self-assigned this Jun 15, 2016

this.trigger({types: types});
});
},
getInitialState() {
return {
types: this.types,

This comment has been minimized.

@edmundoa

edmundoa Jun 15, 2016

Member

With the changes the store state is not used any more, at least I couldn't find any usages.

@edmundoa

This comment has been minimized.

Member

edmundoa commented Jun 15, 2016

LGTM 👍

@edmundoa edmundoa merged commit d58530a into master Jun 15, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 987 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 473 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the issue-2352 branch Jun 15, 2016

edmundoa added a commit that referenced this pull request Jun 15, 2016

Do not init available alarm callback types, fetch them explicitly. (#…
…2353)

* Do not init available alarm callback types, fetch them explicitly.

When we are fetching the available alarm callback types during init of
AlarmCallbacksStore, we don't have a stream id to fetch for yet.
Therefore we are running into permission problems in the backend
resource for non-admin users. This change replaces the init with an
explicit fetch of available alarm callback types in the consumer.

Fixes #2352

* Fixing linter hints.

* Removing now unused store state.

(cherry picked from commit d58530a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment