Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved feedback #2357

Merged
merged 5 commits into from Jun 27, 2016
Merged

Improved feedback #2357

merged 5 commits into from Jun 27, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 15, 2016

This PR adds feedback to buttons triggering actions that may take some time to receive a response from the server. In that way, the user can see the action is being processed and doesn't have to wonder if the click worked or not.

In order to use finally in our promises to reset the loading status, I had to set bluebird as the default promise factory in Reflux. I wrote a bit more about it in 1ae78c0's commit message.

edmundoa added 5 commits Jun 15, 2016
When using the `triggerPromise` method in a Reflux action, Reflux
creates a new promise underneath using the native promise the browser
provides.

The main reason to avoid this is consistency, as bluebird is our library
of choice for promises, and it's strange seeing a promise that behaves
differently. Most importantly, most browsers' promises only have support
for `then` and `catch` methods, and that makes complicated using other
methods as `finally`, as you need to think if the promise you receive is
a bluebird promise or not.
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Jun 15, 2016

I just saw that this fixes #2151

Loading

@dennisoelkers dennisoelkers self-assigned this Jun 21, 2016
@dennisoelkers dennisoelkers merged commit 21c0bcf into master Jun 27, 2016
4 checks passed
Loading
@dennisoelkers dennisoelkers deleted the improved-feedback branch Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants