Make Message#getStreamIds() more reliable #2378
Merged
Conversation
The getStreamIds() method only checked for the existence of the "streams" message field and returned it. This only works for messages which have already been indexed and have that field. For messages in-flight, the method always returned an empty list, even if StreamMatcherFilter had run before. This commit extends getStreamIds() to also query the internal "streams" list which is being populated by the StreamMatcherFilter if the "streams" message field doesn't exist.
|
This should also be ported into the |
dennisoelkers
added a commit
that referenced
this pull request
Jun 20, 2016
The getStreamIds() method only checked for the existence of the "streams" message field and returned it. This only works for messages which have already been indexed and have that field. For messages in-flight, the method always returned an empty list, even if StreamMatcherFilter had run before. This commit extends getStreamIds() to also query the internal "streams" list which is being populated by the StreamMatcherFilter if the "streams" message field doesn't exist. (cherry picked from commit 1aa96fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The
Message#getStreamIds()method only checked for the existence of the "streams" message field and returned it. This only works for messages which have already been indexed and have that field.For messages in-flight, the method always returned an empty list, even if
StreamMatcherFilterhad run before.This commit extends
Message#getStreamIds()to also query the internal "streams" list which is being populated by theStreamMatcherFilterif the "streams" message field doesn't exist.