New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search query on auto refresh #2385

Merged
merged 2 commits into from Jun 20, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Jun 20, 2016

When a search did not return results, clicking on the "Search" navigation menu, does not reset the search query used for auto-refresh.

Removing the query from the SearchPage state fixes the problem, as the search query is properly updated in the SearchStore.

Fixes #2379.

These changes should also be merged into master.

@edmundoa edmundoa added this to the 2.0.3 milestone Jun 20, 2016

@dennisoelkers dennisoelkers self-assigned this Jun 20, 2016

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Jun 20, 2016

This does not fix #2379 though, as it does not retrigger the search request, so when entering a search query and clicking on "Search" in the top navbar, the message list stays the same.

@edmundoa

This comment has been minimized.

Member

edmundoa commented Jun 20, 2016

@dennisoelkers you are right, I misread the original issue, and the fix is not actually fixing what it should. Will update the PR or open a new one if the changes are completely unrelated. Sorry about all the confusion!

edmundoa added some commits Jun 20, 2016

Update search query on SearchStore component
When a search did not return results, clicking on the "Search"
navigation menu, does not reset the search query being used in
`SearchStore`.

Removing the query from the component state fixes part of problem, as the
search query is now updated when the component refreshes the data.

Refs #2379

@edmundoa edmundoa force-pushed the issue-2379 branch from fd6449c to 922f032 Jun 20, 2016

@dennisoelkers dennisoelkers merged commit 90602ff into 2.0 Jun 20, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1003 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 489 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the issue-2379 branch Jun 20, 2016

dennisoelkers added a commit that referenced this pull request Jun 20, 2016

Update search query on auto refresh (#2385)
* Update search query on SearchStore component

When a search did not return results, clicking on the "Search"
navigation menu, does not reset the search query being used in
`SearchStore`.

Removing the query from the component state fixes part of problem, as the
search query is now updated when the component refreshes the data.

Refs #2379

* Refresh search data when location changes

Fixes #2379

(cherry picked from commit 90602ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment