Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "elasticsearch_discovery_zen_ping_multicast_enabled" setting #2394

Merged
merged 1 commit into from Jun 29, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jun 21, 2016

ES multicast discovery has been moved into a plugin in Elasticsearch 2.0.0, been deprecated in Elasticsearch 2.2.0, and will be removed in Elasticsearch 5.0.0.

Additionally, the plugin (https://www.elastic.co/guide/en/elasticsearch/plugins/2.3/discovery-multicast.html) cannot be used with Graylog, so the elasticsearch_discovery_zen_ping_multicast_enabled setting is useless and should be removed.

ES multicast discovery has been moved into a plugin in Elasticsearch 2.0.0,
been deprecated in Elasticsearch 2.2.0, and will be removed in Elasticsearch 5.0.0.

Additionally, the plugin (https://www.elastic.co/guide/en/elasticsearch/plugins/2.3/discovery-multicast.html)
cannot be used with Graylog, so the "elasticsearch_discovery_zen_ping_multicast_enabled"
setting is useless and should be removed.
@joschi joschi added this to the 2.1.0 milestone Jun 21, 2016
@bernd bernd self-assigned this Jun 29, 2016
@bernd
Copy link
Member

@bernd bernd commented Jun 29, 2016

@joschi The multicast settings need to be removed from the Chef cookbook (and maybe other projects) as well.

@bernd
Copy link
Member

@bernd bernd commented Jun 29, 2016

Otherwise LGTM

@bernd bernd merged commit 7ccce9b into master Jun 29, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 1004 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 490 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the remove-es-multicast branch Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.