Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting our customized ESLint config into separate module. #2441

Merged
merged 2 commits into from Jul 1, 2016

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jun 30, 2016

This module is consumable by plugins too, so we are one step closed to
establishing consistent code quality.

All changes to the ESLint config should be done in the module from now
on, so they propagate to plugins consuming it as well.

This module is consumable by plugins too, so we are one step closed to
establishing consistent code quality.
All changes to the ESLint config should be done in the module from now
on, so they propagate to plugins consuming it as well.
@edmundoa edmundoa self-assigned this Jun 30, 2016
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jul 1, 2016

LGTM 👍

@edmundoa edmundoa merged commit 4ba62bc into master Jul 1, 2016
3 checks passed
3 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 526 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@edmundoa edmundoa deleted the extract-eslint-config-module branch Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants