Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exceptions more useful by providing messages and context #2478

Merged
merged 2 commits into from Jul 14, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jul 14, 2016

Some exceptions were missing a proper message and lost context (e. g. by not using the original exception for its stack trace).

Especially with exceptions thrown in JAX-RS resource classes, this leaves users with an error response without mentioning the reason for the failing request.

@joschi joschi added this to the 2.1.0 milestone Jul 14, 2016
@dennisoelkers dennisoelkers self-assigned this Jul 14, 2016
Jochen Schalanda
@dennisoelkers dennisoelkers merged commit dda30b2 into master Jul 14, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 1087 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 573 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dennisoelkers dennisoelkers deleted the verbose-exceptions branch Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.