Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Guice modules for journal-related commands #2495

Merged
merged 2 commits into from Jul 19, 2016
Merged

Add missing Guice modules for journal-related commands #2495

merged 2 commits into from Jul 19, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jul 18, 2016

After merging #2312, the KafkaJournal class depends on more dependencies from the Graylog code base which were missing in the AbstractJournalCommand.

Fixes #2493

@bernd
Copy link
Member

@bernd bernd commented Jul 19, 2016

LGTM 👍

@bernd bernd merged commit f115f59 into master Jul 19, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1101 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 587 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the issue-2493 branch Jul 19, 2016
@bernd bernd self-assigned this Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants