Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordering of decorators and decoration stats to UI #2499

Merged
merged 23 commits into from Jul 22, 2016

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jul 19, 2016

  • adds ordering of decorators (by using drag and drop) to the decorator sidebar.
  • shows in message details which fields are decorated, allows to toggle displaying original content, disabled field actions for added fields.

Requires merging of #2482.

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Jul 19, 2016
@dennisoelkers dennisoelkers force-pushed the add-ordering-and-decoration-stats branch from 05b73ca to 7e1a20f Jul 20, 2016
@kroepke
Copy link
Member

@kroepke kroepke commented Jul 20, 2016

Overall this looks really good, but there are some rough edges:

  • Synthetic fields in the sidebar are not marked as such, so the quickvalues etc dropdown is shown, but those functions don't work right now
  • Drag'n'drop reordering sometimes applies too early, leading to jumbled results:
    image
  • creating/deleting decorators does not re-render the UI immediately right now
Also marking them as decorated and including a helpful explanation in
tooltip.
The PluginStore does not prevent double registration of plugins/exports.
This is a workaround to prevent double registration of field analyzers
due to the package index being included in the core _and_ at least one
plugin. The proper fix would be to prevent double plugin registration,
but this is beyond the scope of this PR.
@kroepke
Copy link
Member

@kroepke kroepke commented Jul 22, 2016

Looks good to me, the only thing that is breaking right now is the following, but I think we can fix this in a subsequent bug fix. If you agree, I'd merge this.

  1. Add a pipeline decorator that adds a simple static field to messages.
  2. Select the field to show in the message table.
  3. Remove the decorator from the result.
  4. The field is still show as a table column.
@kroepke
Copy link
Member

@kroepke kroepke commented Jul 22, 2016

Agreed to fix the remaining issue offline, I'll create a ticket.

@kroepke kroepke merged commit 51d5bc9 into master Jul 22, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1137 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 623 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kroepke kroepke deleted the add-ordering-and-decoration-stats branch Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants