Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt reading DSA key if RSA failed #2503

Closed
wants to merge 1 commit into from
Closed

Attempt reading DSA key if RSA failed #2503

wants to merge 1 commit into from

Conversation

@mikkolehtisalo
Copy link
Contributor

@mikkolehtisalo mikkolehtisalo commented Jul 19, 2016

Simple fix sans tests for #2454. Feel free to reject and close, or refine further! More explanation at #2454.

final KeyFactory RSAkf = KeyFactory.getInstance("RSA");
return RSAkf.generatePrivate(keySpec);
} catch (InvalidKeySpecException e) {
LOG.debug("Generating RSA private key failed", e);
Copy link
Member

@lennartkoopmann lennartkoopmann Jul 19, 2016

IMO this should say that we are trying to generate a DSA key instead and not all hope is lost yet.

Copy link
Contributor Author

@mikkolehtisalo mikkolehtisalo Jul 20, 2016

Good point. Rephrased. I will take a look at the tests next :P

Rephrased debug log

Tests for DSA key support in KeyUtil
@joschi joschi self-assigned this Jul 20, 2016
@joschi joschi added this to the 2.1.0 milestone Jul 20, 2016
joschi pushed a commit that referenced this issue Jul 22, 2016
@joschi
Copy link
Contributor

@joschi joschi commented Jul 22, 2016

@mikkolehtisalo Thank you very much!

Merged in 97521bf (after updating the log message).

@joschi joschi closed this Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants