New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt reading DSA key if RSA failed #2503

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mikkolehtisalo
Contributor

mikkolehtisalo commented Jul 19, 2016

Simple fix sans tests for #2454. Feel free to reject and close, or refine further! More explanation at #2454.

final KeyFactory RSAkf = KeyFactory.getInstance("RSA");
return RSAkf.generatePrivate(keySpec);
} catch (InvalidKeySpecException e) {
LOG.debug("Generating RSA private key failed", e);

This comment has been minimized.

@lennartkoopmann

lennartkoopmann Jul 19, 2016

Member

IMO this should say that we are trying to generate a DSA key instead and not all hope is lost yet.

This comment has been minimized.

@mikkolehtisalo

mikkolehtisalo Jul 20, 2016

Contributor

Good point. Rephrased. I will take a look at the tests next :P

Attempt reading DSA key if RSA failed
Rephrased debug log

Tests for DSA key support in KeyUtil

@joschi joschi self-assigned this Jul 20, 2016

@joschi joschi added the improvement label Jul 20, 2016

@joschi joschi added this to the 2.1.0 milestone Jul 20, 2016

joschi added a commit that referenced this pull request Jul 22, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Jul 22, 2016

@mikkolehtisalo Thank you very much!

Merged in 97521bf (after updating the log message).

@joschi joschi closed this Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment