New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default to make REST API and web if to listen on same host/port #2525

Merged
merged 4 commits into from Jul 26, 2016

Conversation

Projects
None yet
5 participants
@dennisoelkers
Member

dennisoelkers commented Jul 25, 2016

This PR changes the defaults of the configuration to make the web interface use the same listener as the default REST API.

Needs to be merged after #2515

Fixes #2446

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Jul 25, 2016

@dennisoelkers dennisoelkers force-pushed the make-single-port-the-default branch from 9bcb1c2 to 8ab35d0 Jul 26, 2016

@bernd

This comment has been minimized.

Member

bernd commented Jul 26, 2016

How about using web instead of console? The latter sounds weird to me and we are using "web interface" when we are talking about the web interface. 😉

@joschi joschi self-assigned this Jul 26, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Jul 26, 2016

@bernd I don't have a strong opinion in this matter and I'm fine with either.
@dennisoelkers any comments?

@kroepke

This comment has been minimized.

Member

kroepke commented Jul 26, 2016

I'd either go for web or simply graylog as the default.

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Jul 26, 2016

/console was chosen because it seemed to be the most appropriate semantically. /web seems to be like using /foo because it basically means nothing these days. I would still go with /console as it is only the default.

@joschi joschi merged commit ea063a4 into master Jul 26, 2016

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci-server-integration Jenkins build graylog2-server-integration-pr 1160 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 643 has succeeded
Details

@joschi joschi deleted the make-single-port-the-default branch Jul 26, 2016

Graylog 2.0.x has been using separate listeners for the REST API and the web interface by default. The Graylog REST API on ``http://127.0.0.1:12900``, the Graylog web interface on ``http://127.0.0.1:9000``.
Beginning with Graylog 2.1.0 it is possible to run both the REST API and the web interface on the same host/port-combination and this is now the default. This means that the REST API is still running on ``http://127.0.0.1:12900`` per default, but the web interface is now running on ``http://127.0.0.1:12900/web``.
Furthermore, all requests going to ``http://127.0.0.1:12900/`` requesting a content-type of ``text/html`` or ``application/xhtml+xml`` are redirected to the web interface, therefore making it even easier to set up Graylog and use it behind proxies, expose it externally etc.

This comment has been minimized.

@shishkin

shishkin Aug 3, 2016

It's not the behavior I observe with docker image 2.1.0-beta2-1. Web UI still starts on 9000 by default. Wen I overwrite web_listen_uri with http://0.0.0.0:12900/web the UI fails by redirecting to that literal 0.0.0.0 IP and web_transport_uri has no effect.

This comment has been minimized.

@joschi

joschi Aug 3, 2016

Contributor

@shishkin Please create a new issue for this (if there is none yet covering the same problem).

Comments on PR commits can easily be overlooked and badly be tracked, especially if the PR is already closed.

This comment has been minimized.

@shishkin

shishkin Aug 3, 2016

Sure, here it is: #2606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment