Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that Elasticsearch home/data paths are readable #2538

Merged
merged 1 commit into from Jul 26, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jul 26, 2016

These validations will ensure that cases like #2536 result in a better error message.

throw new ValidationException("Path " + path.toAbsolutePath() + " is not a directory.");
}

if (Files.exists(path) && !Files.isReadable(path)) {

This comment has been minimized.

@bernd

bernd Jul 26, 2016
Member

Is there a case where the directory also needs to be writable? If so, we should also test for that.

This comment has been minimized.

@joschi

joschi Jul 26, 2016
Author Contributor

It has to be writable if data is being stored (elasticsearch_node_data). Other than that, I haven't found a case for which it had to be writable.

Funny enough, the directories don't even have to exist, it's sufficient if the parent directory is there.

This comment has been minimized.

@bernd

bernd Jul 26, 2016
Member

the 👎 was wrong 😄

This comment has been minimized.

@joschi

joschi Jul 26, 2016
Author Contributor

@bernd
Copy link
Member

@bernd bernd commented Jul 26, 2016

LGTM 👍

@bernd bernd merged commit 958a335 into master Jul 26, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1161 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 644 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the validate-elasticsearch-paths branch Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants