New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator UI Fixes #2539

Merged
merged 2 commits into from Jul 27, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jul 26, 2016

Some minor fixes for decorator UI.

These include:

  • resetting the decorators form so old values are not kept on cancel
  • making add decorator component pure, to prevent flickering in select
  • checking if SearchPage is mounted before setting state in callback
  • adjusting the styles of some components to make layout consistent between Chrome and Safari

dennisoelkers added some commits Jul 26, 2016

Some minor fixes for decorator UI.
These include:

  - resetting the decorators form so old values are not kept on cancel
  - making add decorator component pure, to prevent flickering in select
  - checking if SearchPage is mounted before setting state in callback

@dennisoelkers dennisoelkers added the web label Jul 26, 2016

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Jul 26, 2016

@edmundoa edmundoa self-assigned this Jul 26, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Jul 27, 2016

LGTM 👍

@edmundoa edmundoa merged commit eacb574 into master Jul 27, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the decorator-fixes branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment