New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for HttpHeadersToken pass actual remote address #2556

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Jul 27, 2016

the "host" will be the actual client host in case trusted_proxies are set.
for the SSO plugin we need to know the actual remote address, which will be the proxy closest to Graylog, to verify that the proxy is ok to set the user header
otherwise we cannot verify anything

This is necessary for the SSO plugin to work in the current state on master.

for HttpHeadersToken pass actual remote address
the "host" will be the actual client host in case trusted_proxies are set.
for the SSO plugin we need to know the actual remote address, which will be the proxy closest to Graylog, to verify that the proxy is ok to set the user header
otherwise we cannot verify anything

@kroepke kroepke added this to the 2.1.0 milestone Jul 27, 2016

@joschi joschi self-assigned this Jul 28, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Jul 28, 2016

LGTM. 👍

@joschi joschi merged commit 662866c into master Jul 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the http-headers-remoteaddr branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment